New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Directory structure #694
Refactor Directory structure #694
Conversation
…efactor-dir-structure
@utam0k Apologies for such a big PR 😓 😓 , but most are moved files. Take a look whenever possible for you, and let me know if any changes are required. Thanks :) |
It appears that the same issue is also failing this CI , with same 3 capabilites :
|
I'll check this PR next my holiday! But it seems this PR has conflicts. Can I ask you to solve it? |
Hey, no issues, take your time :) |
integration_tests/rust-integration-tests/integration_test/Cargo.toml
Outdated
Show resolved
Hide resolved
It would be nice if the make command could work from the top of the directory, is that possible? |
…efactor-dir-structure
85b442b
to
c0946b1
Compare
c0946b1
to
8a8cc29
Compare
…efactor-dir-structure
063d1c6
to
40e7b74
Compare
Hey @utam0k finally the CI is done 😅 |
@YJDoc2 Can I ask you to update the README and resolve conflicts since the path to |
de67a26
to
9f7ceb5
Compare
…efactor-dir-structure
9f7ceb5
to
b2ec0d9
Compare
@utam0k please take a look :) |
@YJDoc2 Can I ask you to update this? |
Hey @utam0k I have updated the readme and docs tutorial, please check |
…efactor-dir-structure
Hey, the conflicts are resolved, the CI is passing, and currently there are no other PRs open! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Apologies for the big PR, but major of the changes are moved files.
This PR does some needed refactoring of directory structure, which will make it easier to understand and work on youki.
Major Changelog :
This PR will form the first step for #601 , and does not complete it. I made this PR, as even by itself it is quite big, and I did not want to make the review more hard. After this is merged, the next steps in separate PRs will be :
When testing on my own fork, I noticed that the oci-integration-tests were failing, but not because of changes I made, but because one of the go tests was failing. Adding its link here, in case the same happens in this PR : https://github.com/YJDoc2/youki/runs/5091082926?check_suite_focus=true