Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Create tmp dir #40

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Create tmp dir #40

merged 3 commits into from
Oct 24, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Oct 19, 2018

Create tmp dir so buffering works

scratch/tmpl.Dockerfile Outdated Show resolved Hide resolved
Move for cache
@dduportal
Copy link
Contributor

This directory should also be declared as a data volume by default: if it the kind of FS operations done inside is buffering or caching, then better to have it by default outside the layer caching.

scratch/tmpl.Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur merged commit 16de5af into master Oct 24, 2018
@mmatur mmatur deleted the dtomcej-patch-1 branch October 24, 2018 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants