Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck tests and doc #1132

Merged
merged 4 commits into from
Feb 21, 2017
Merged

Healthcheck tests and doc #1132

merged 4 commits into from
Feb 21, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Feb 7, 2017

No description provided.

@juliens juliens changed the title Healthcheck Healthcheck tests and doc Feb 7, 2017
@emilevauge emilevauge changed the base branch from master to v1.2 February 8, 2017 19:25
@emilevauge emilevauge added this to the 1.2 milestone Feb 17, 2017
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @juliens :)

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@shouze
Copy link

shouze commented Feb 17, 2017

@juliens ok so, to make it clear, what about providers? #708 Do we have to redefine healthchecks trhough labels? Maybe it could be described in the doc?

@rogeriollacerda
Copy link

@juliens is possible to use healthcheck feature as a Marathon label? Something like this:

traefik.HealthCheck.Interval=10
traefik.HealthCheck.URL=/health

Tks!

@timoreimann
Copy link
Contributor

@rogeriollacerda could you please create a new issue for your request? Thanks!

@rogeriollacerda
Copy link

@timoreimann Sure! Thanks

@timoreimann
Copy link
Contributor

@rogeriollacerda's follow-up is at #1232.

@ldez ldez added the kind/enhancement a new or improved feature. label Apr 29, 2017
@juliens juliens deleted the healthcheck branch September 13, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants