Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that provider-enabling argument parameters set all defaults. #1830

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Clarify that provider-enabling argument parameters set all defaults. #1830

merged 1 commit into from
Jul 6, 2017

Conversation

timoreimann
Copy link
Contributor

Motivated by this Stackoverflow answer.

Emile and @containous/traefik: PTAL.

emilevauge
emilevauge approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timoreimann 👍
LGTM

ldez
ldez approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez modified the milestone: 1.4 Jul 5, 2017
vdemeester
vdemeester approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💃

@ldez ldez force-pushed the include-default-settings-in-provider-enabling-wording branch from d2b8ac5 to 02fd210 Compare July 6, 2017 14:37
@ldez ldez merged commit a89eb12 into traefik:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@timoreimann @vdemeester @ldez @emilevauge