bug command.
#2178
Merged
bug command.
#2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traefiker
added
area/authentication
area/middleware
area/provider/boltdb
area/provider/consul
area/provider/docker
area/provider/ecs
area/provider/etcd
area/provider/eureka
area/provider/k8s/ingress
area/provider/marathon
area/provider/mesos
area/provider/rancher
size/L
status/0-needs-triage
labels
ldez
added
status/2-needs-review
and removed
area/provider/mesos
area/provider/rancher
status/0-needs-triage
labels
ldez
force-pushed
the
fix/bug-command
branch
from
a3e58b6
to
91caae3
Compare
mmatur
reviewed
Sep 28, 2017
provider/mesos/mesos.go
Outdated
| GroupsAsSubDomains bool `description:"Convert Mesos groups to subdomains" export:"true"` | ||
| ZkDetectionTimeout int `description:"Zookeeper timeout (in seconds)" export:"true"` | ||
| RefreshSeconds int `description:"Polling interval (in seconds)" export:"true"` | ||
| // e.g. "host", "docker", "mesos", "rkt" |
There was a problem hiding this comment.
Unnecessary comment, already present in IPSources description
ldez
force-pushed
the
fix/bug-command
branch
from
91caae3
to
f5e935e
Compare
emilevauge
reviewed
Sep 29, 2017
ldez
force-pushed
the
fix/bug-command
branch
from
f5e935e
to
6b23f7a
Compare
|
@emilevauge done. |
ldez
force-pushed
the
fix/bug-command
branch
from
6b23f7a
to
0965f9d
Compare
mmatur
reviewed
Sep 29, 2017
cmd/traefik/anonymize/anonymize.go
Outdated
| return string(fieldName[0]) == strings.ToUpper(string(fieldName[0])) | ||
| } | ||
|
|
||
| func marshal(obfuscatedConfig interface{}, indent bool) ([]byte, error) { |
ldez
force-pushed
the
fix/bug-command
branch
from
0965f9d
to
9e56edc
Compare
ldez
force-pushed
the
fix/bug-command
branch
from
0b5f195
to
320f33c
Compare
|
👏 LGTM |
traefiker
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
bugcommand, some fields (like token, password, ...) are not anonymized.This PR fixes this problem.