-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug
command.
#2178
bug
command.
#2178
Conversation
a3e58b6
to
91caae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
provider/mesos/mesos.go
Outdated
GroupsAsSubDomains bool `description:"Convert Mesos groups to subdomains" export:"true"` | ||
ZkDetectionTimeout int `description:"Zookeeper timeout (in seconds)" export:"true"` | ||
RefreshSeconds int `description:"Polling interval (in seconds)" export:"true"` | ||
// e.g. "host", "docker", "mesos", "rkt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary comment, already present in IPSources description
91caae3
to
f5e935e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, it would be a good idea to move from obfuscate (to make obscure, to darken), to anonymize. Our mechanism makes it impossible to get the initial info, which is not what means obfuscate.
WDYT ?
f5e935e
to
6b23f7a
Compare
@emilevauge done. |
6b23f7a
to
0965f9d
Compare
cmd/traefik/anonymize/anonymize.go
Outdated
return string(fieldName[0]) == strings.ToUpper(string(fieldName[0])) | ||
} | ||
|
||
func marshal(obfuscatedConfig interface{}, indent bool) ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be anomConfig no ?
0965f9d
to
9e56edc
Compare
0b5f195
to
320f33c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 @ldez
LGTM
👏 LGTM |
Description
In the
bug
command, some fields (like token, password, ...) are not anonymized.This PR fixes this problem.