Add tests for TLS dynamic configuration in ETCD3 #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
requested changes
Dec 21, 2017
There was a problem hiding this comment.
Hello @dahefanteng .
Many thanks for your PR. But the bug seems to be fixed in PR #2603.
However yout Etcd test is very interesting.
WDYT about :
- Rebasing your PR on the branch v1.5,
- Deleting the code in server.go and keeping the test.
dahefanteng
force-pushed
the
fix-deletetls-bug
branch
from
35a5015
to
522cbb2
Compare
|
@nmengin I have rebase the PR and delete code in server.go |
nmengin
changed the title
nmengin
approved these changes
Dec 21, 2017
integration/etcd3_test.go
Outdated
| defer display(c) | ||
|
|
||
| // prepare to config | ||
| whoami1IP := s.composeProject.Container(c, "whoami1").NetworkSettings.IPAddress |
There was a problem hiding this comment.
Please use the constant ipWhoami01 instead of the variable whoami1IP
integration/etcd3_test.go
Outdated
|
|
||
| // prepare to config | ||
| whoami1IP := s.composeProject.Container(c, "whoami1").NetworkSettings.IPAddress | ||
| whoami2IP := s.composeProject.Container(c, "whoami2").NetworkSettings.IPAddress |
There was a problem hiding this comment.
Please use the constant ipWhoami02 instead of the variable whoami2IP
integration/etcd3_test.go
Outdated
| defer cmd.Process.Kill() | ||
|
|
||
| // wait for Træfik | ||
| err = try.GetRequest("http://127.0.0.1:8081/api/providers", 60*time.Second, try.BodyContains(string("MIIEpQIBAAKCAQEA1RducBK6EiFDv3TYB8ZcrfKWRVaSfHzWicO3J5WdST9oS7h"))) |
There was a problem hiding this comment.
Please use constant traefikWebEtcdURL instead of http://127.0.0.1:8081
integration/etcd3_test.go
Outdated
| } | ||
|
|
||
| // waiting for Træfik to pull configuration | ||
| err = try.GetRequest("http://127.0.0.1:8081/api/providers", 30*time.Second, try.BodyNotContains("MIIEpQIBAAKCAQEA1RducBK6EiFDv3TYB8ZcrfKWRVaSfHzWicO3J5WdST9oS7h")) |
There was a problem hiding this comment.
Please use constant traefikWebEtcdURL instead of http://127.0.0.1:8081
nmengin
requested changes
Dec 21, 2017
|
@nmengin Really appreciate your patience,Thank you! |
traefiker
force-pushed
the
fix-deletetls-bug
branch
from
2abee92
to
3a0729d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When I delete all the tls cert/key pairs in my etcd(v3),the debug log and api(/api/providers) show traefik has read configurations which has an empty tlsconfigure.But Actually it does't work.
After reading the code,I think traefik skip delete when the all the tlsconfigurations in etcd be deleted in a very short time.
And I wrote some test for this.
Motivation
when i write test case in my own project,I delete the tls cert/key pairs,expecting recevie the "TRAEFIK DEFAULT CERT" from traefik,but what i receive is still the deleted one after a very long wait.
More
Additional Notes