Skip to content

Conversation

@nmengin
Copy link
Contributor

@nmengin nmengin commented Dec 20, 2017

What does this PR do?

The PR fixes TLS dynamic management by allowing deleting all of certificates from an entryPoint.

Motivation

The entryPoints kept at least one certificate even if user delete all of them from the configuration, the PR fixes this behavior.

More

  • Added/updated tests

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1e44e33 into traefik:v1.5 Dec 21, 2017
@nmengin nmengin deleted the hotfix/delete-dynamic-certs-with-nil-list branch August 3, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants