Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong tag in forward span in tracing middleware #3279

Merged
merged 1 commit into from
May 8, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented May 7, 2018

What does this PR do?

This PR fix a bad http.url tag in forward span in tracing middleware

Motivation

Fixes #3273

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Fix bad tag in forward span in tracing middleware Fix wrong tag in forward span in tracing middleware May 7, 2018
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@m3co-code m3co-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b02381c into traefik:v1.6 May 8, 2018
@mmatur mmatur deleted the fix/opentracing-forward-url branch June 19, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants