Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more K8s Unit Tests #3583

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Add more K8s Unit Tests #3583

merged 6 commits into from
Jul 10, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jul 9, 2018

What does this PR do?

Adds more tests

Motivation

Tests are good.

More

  • Added/updated tests

Additional Notes

Removed unreachable case in rule switch

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur self-requested a review July 10, 2018 06:16
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b2a57ca into traefik:v1.7 Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants