Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain is also optional for "normal" mode #4086

Merged
merged 1 commit into from Oct 23, 2018
Merged

Domain is also optional for "normal" mode #4086

merged 1 commit into from Oct 23, 2018

Conversation

herver
Copy link
Contributor

@herver herver commented Oct 20, 2018 •
edited

What does this PR do?

Fixes #4056

Motivation

Improve documentation and keep configuration as small and useful as possible without clutter

More

  • Added/updated documentation

Additional informations

Couldn't get the last line to not show up in the commit 馃樋

@herver herver requested a review from a team as a code owner October 20, 2018 15:39
@ldez ldez changed the title domain is also optional for "normal" mode (#4056) domain is also optional for "normal" mode Oct 23, 2018
@ldez ldez mentioned this pull request Oct 23, 2018
Merged
1 task
ldez
ldez approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the request for review from a team October 23, 2018 15:09
juliens
juliens approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 1.7 milestone Oct 23, 2018
@herver herver requested review from a team as code owners October 23, 2018 15:19
@ldez ldez changed the base branch from master to v1.7 October 23, 2018 15:19
@traefiker traefiker merged commit 99ddd7f into traefik:v1.7 Oct 23, 2018
@traefiker traefiker mentioned this pull request Oct 23, 2018
Closed
@ldez ldez changed the title domain is also optional for "normal" mode Domain is also optional for "normal" mode Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@herver @juliens @jbdoumenjou @ldez @traefiker