Skip to content

Conversation

@herver
Copy link
Contributor

@herver herver commented Oct 20, 2018

What does this PR do?

Fixes #4056

Motivation

Improve documentation and keep configuration as small and useful as possible without clutter

More

  • Added/updated documentation

Additional informations

Couldn't get the last line to not show up in the commit 😿

@herver herver requested a review from a team as a code owner October 20, 2018 15:39
@ldez ldez changed the title domain is also optional for "normal" mode (#4056) domain is also optional for "normal" mode Oct 23, 2018
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the request for review from a team October 23, 2018 15:09
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 99ddd7f into traefik:v1.7 Oct 23, 2018
@ldez ldez changed the title domain is also optional for "normal" mode Domain is also optional for "normal" mode Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants