Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IngressEndpoint in CRD provider #4616

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Remove IngressEndpoint in CRD provider #4616

merged 2 commits into from
Mar 18, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Mar 18, 2019

What does this PR do?

Remove IngressEndpoint in the CRD provider.

Motivation

Remove IngressEndpoint because it doesn't exist in the CRD Provider

@ldez ldez added this to the next milestone Mar 18, 2019
@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. and removed bot/light-review decreases the number of required LGTM from 3 to 1. labels Mar 18, 2019
ldez
ldez approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the bot/no-merge label Mar 18, 2019
@traefiker traefiker merged commit 50e24f4 into traefik:master Mar 18, 2019
@juliens juliens deleted the clean-k8scrd branch September 6, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @geraldcroes @jbdoumenjou @ldez @traefiker