Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance k8s tests maintainability #4696

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Enhance k8s tests maintainability #4696

merged 2 commits into from
Apr 1, 2019

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 30, 2019

What does this PR do?

Use yaml instead of code.

Motivation

Enhance k8s tests maintainability

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez requested a review from a team as a code owner March 30, 2019 00:30
@traefiker traefiker added this to the 1.7 milestone Mar 30, 2019
dtomcej
dtomcej approved these changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work!
LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the bot/no-merge label Apr 1, 2019
@traefiker traefiker merged commit 86d700c into traefik:v1.7 Apr 1, 2019
@ldez ldez deleted the refactor/k8s_tests branch April 1, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress area/provider/k8s kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @jbdoumenjou @dtomcej @traefiker