Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove first byte wait when tcp catches all #4938

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Jun 6, 2019

What does this PR do?

Forward directly the tcp traffic when only one router without TLS and rule HostSNI("*") is configured on an entrypoint.

Motivation

To be able to handle when a protocol needs a connection confirmation without sending any bytes.
Fixes #4875

More

  • Added/updated tests
    - [ ] Added/updated documentation

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants