API: remove configuration of Entrypoint and Middlewares #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpl
added
area/api
kind/enhancement
ldez
added
contributor/waiting-for-documentation
and removed
contributor/waiting-for-corrections
labels
ldez
added
status/3-needs-merge
bot/no-merge
and removed
status/2-needs-review
status/3-needs-merge
bot/no-merge
labels
This comment has been minimized.
This comment has been minimized.
davidalger
added a commit
to wardenenv/warden
that referenced
this pull request
Sep 19, 2019
This resolves "command traefik error: field not found, node: redirect" errors that put Traefik into an endless restart loop. See traefik/traefik#5119 for changes causing the BC break; this is a problem since Warden currently leverages the removed configuration settings in the TOML file that's generated and passed into the Traefik container. Thanks to @magedevjosh for finding and reporting this issue!
2 tasks
ldez
pushed a commit
to waitingsong/traefik
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the Middlewares and Entrypoint fields of the API handler configuration. As we're probably going to redo the routing and TLS handling (among other things) of other handlers (such as Ping, Rest provider, Prometheus metrics, etc) in the same way we're going to do it for the API handler, this PR also removes similarly extraneous fields for these as well.
Motivation
This change comes in preparation of a a rework of the API handler configuration, which will define how traffic is routed to it, how we handle TLS with it, etc.
We envision that the Entrypoint and Middlewares are not going to be part of its configuration anymore when we redo it, so remove them as of now, so that we don't have to break the configuration later on.
More
Additional Notes
Co-authored-by: Julien Salleyron julien.salleyron@gmail.com