Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove field api.entryPoint #5776

Merged
merged 6 commits into from Nov 8, 2019
Merged

docs: remove field api.entryPoint #5776

merged 6 commits into from Nov 8, 2019

Conversation

waitingsong
Copy link
Contributor

@waitingsong waitingsong commented Nov 5, 2019

What does this PR do?

Remove field api.entryPoint in traefik.sample.toml, though commented out.

Motivation

ref: #5119

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@waitingsong
Copy link
Contributor Author

ok, tomorrow.

@ldez ldez changed the base branch from master to v2.0 November 6, 2019 06:51
@ldez ldez added this to the 2.0 milestone Nov 6, 2019
@ldez ldez removed the bot/no-merge label Nov 6, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added the kind/bug/fix a bug fix label Nov 6, 2019
@ldez
Copy link
Member

ldez commented Nov 6, 2019

FYI, you don't need to update (merge) manually, we have bot for that.

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2294025 into traefik:v2.0 Nov 8, 2019
v2 automation moved this from To review to Done Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants