Do not follow redirects for the health check URLs #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coder-hugo
force-pushed
the
feature/no-redirect-on-healthcheck
branch
from
27d2030
to
f92aae0
Compare
dtomcej
added
area/healthcheck
kind/enhancement
SantoDE
approved these changes
Jul 24, 2019
dtomcej
added
status/2-needs-review
and removed
bot/no-merge
status/1-needs-design-review
labels
ldez
force-pushed
the
feature/no-redirect-on-healthcheck
branch
from
f92aae0
to
2b77869
Compare
|
Hello @coder-hugo, We think that not following the redirect for the health check makes sense but we can't integrate it like that without risking breaking existing users relying on the current behavior. WDYT about integrating it as an health check option? |
ldez
force-pushed
the
feature/no-redirect-on-healthcheck
branch
from
3bfe71b
to
94ff137
Compare
mpl
reviewed
Feb 26, 2020
traefiker
force-pushed
the
feature/no-redirect-on-healthcheck
branch
from
934c907
to
e565e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR avoids that the health checker follows HTTP redirects.
Motivation
The default behavior of the go HTTP client is to follow redirects and stop after 10 consecutive requests (see). I wouldn't expect this from a health checker. A redirect could point to a completely different host which is broken. The result of this would be that traefik removes a healthy backend.
More
Additional Notes