Update deprecated function call in k8s providers

[Wagum]

What does this PR do?

Remove the usage of deprecated SharedInformerFactory in kubernetes providers.

Motivation

The kubernetes providers should use NewSharedInformerFactoryWithOptions(), due to the fact that NewFilteredSharedInformerFactory() is deprecated and may get removed in future releases.

[Wagum]

I see that the crd client is also using this function call. Should this be also refactored?
And there is a deprecation management issue on 2.0 milestone (#2212). Maybe just add this to the list in this issue.

[dtomcej]

Hello @Wagum,

Thanks for this!

You are correct, we should also investigate using informers.WithTweakListOptions to use labelselectors instead of filtering later on.

We should also look at updating the CRD provider to use NewSharedInformerFactoryWithOptions too. Ideally this would be in this PR for consistency.

[Wagum]

Hey @dtomcej ,

im going to add the call on NewSharedInformerFactoryWithOptions to the k8s CRD provider as well.

I was concerned about adding informers.WithTweakListOptions to the factory, because the ListOption from TweakListOptionsFunc will apply to all objects, that the factory provides.
(i could not identify kubernetes object types inside the TweakListOptionsFunc, becuase only ListOptions are passed into it).

This means, that you would have to add the ingressLabelSelector to the corresponding secrets, endpoints and services inside the k8s cluster as well.

An other option would be using two factories. One for ingresses including the TweakListOption for labelSelectors, and one further factory for secrets, endpoints and services. This second factory should not use the TweakListOption. I think you implemented something similar in the crd factory for Kubernetes.

Im going to rethink about this and propose a solution to you asap.
Please let me know, what you think about this after investigating with your team :)

[ldez]

Thanks 👍

[jbdoumenjou]

LGTM

[dtomcej]

LGTM