Web UI: Take off logic from generic table component #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieuh
changed the title
ldez
added
kind/enhancement
traefiker
force-pushed
the
take-off-logic-from-table-component
branch
from
2e67586
to
84f3776
Compare
|
Waiting for the merge back of v2.1 in master |
ldez
force-pushed
the
take-off-logic-from-table-component
branch
from
84f3776
to
e7894f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Take off logic from generic table component
Motivation
Some display logics are in the generic MainTable vue component (like list of columns based on a type prop).