Add edge case for root path with rewrite-target #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
kind/bug/fix
|
Tested on own docker image builded with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
Motivation
Fixes #5990
More
Additional Notes
This edge case was where we trim the trailing slashes on the rewrite-target before appending the contents of the matched path. This behavior was required becuase it ensures that we don't duplicate slashes.
However, it introduced an edge case where if the trailing slash was the leading slash, it could get lost.
This is that edge case. The solution here is to capture the leading slash as part of the path capture group, and append it to the rewrite target.