Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PreferServerCipherSuites as a TLS Option #6248

Merged
merged 7 commits into from
Feb 12, 2020
Merged

Allow PreferServerCipherSuites as a TLS Option #6248

merged 7 commits into from
Feb 12, 2020

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jan 28, 2020

What does this PR do?

This PR Allows the configuration of PreferServerCipherSuites independently of other TLS options.

Motivation

Fixes #6228

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez self-requested a review January 28, 2020 11:24
jbdoumenjou
jbdoumenjou requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the TLSOption configuration in the kubernetesCRD provider ?

@jbdoumenjou
Copy link
Member

Could you update the reference/dynamic-configuration for both the file and KubernetesCRD with the new option?

jbdoumenjou
jbdoumenjou approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops after a second look, I found a bug

pkg/provider/kubernetes/crd/traefik/v1alpha1/tlsoption.go Show resolved Hide resolved
@ldez ldez added this to the next milestone Feb 12, 2020
juliens
juliens approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7c430e5 into traefik:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/tls kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Cipher Suites Order missing
5 participants
@dtomcej @jbdoumenjou @juliens @ldez @traefiker