Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLSStores to Kubernetes CRD #6270

Merged
merged 13 commits into from
Feb 24, 2020
Merged

Add TLSStores to Kubernetes CRD #6270

merged 13 commits into from
Feb 24, 2020

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Feb 3, 2020

What does this PR do?

This PR Adds the TLS Stores functionality to the CRD, allowing kubernetes users the ability to provide default certificates without using config files and mounting certificates.

Motivation

Fixes #5468

More

  • Added/updated tests - more may be needed
  • Added/updated documentation

Additional Notes

For some reason make validate seemed to update the kv-ref doc, but idk why 🤷‍♂

@dtomcej
Copy link
Contributor Author

dtomcej commented Feb 5, 2020

Blocked on TLS Store naming question

pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to specify default TLS certificate for Kubernetes CRD
5 participants