-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to use BindPort IPAddress 👼 #657
Conversation
/cc @tqoliver |
Thanks @vdemeester :) , could you also update the doc? |
91bcffe
to
a17f189
Compare
@emilevauge does the name of the flag looks good ? 😝 |
4290204
to
679c4bd
Compare
@@ -34,6 +34,7 @@ type Docker struct { | |||
Domain string `description:"Default domain used"` | |||
TLS *ClientTLS `description:"Enable Docker TLS support"` | |||
ExposedByDefault bool `description:"Expose containers by default"` | |||
UseBindPortIP bool `description:"Use the ip address from the port binded instead of the inner network one"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description could be a bit better here, the language feels a bit awkward...
Perhaps this would be better:
"Use the ip address from the bound port, rather than from the inner network"
This looks good to me... I quite like the name of the flag, its clear what it does :) |
Looks good to me, apart few comments :) |
679c4bd
to
f6c8d01
Compare
f6c8d01
to
b867547
Compare
Ping @vdemeester :) |
arf conflict on |
Do you still want to add an integration test? |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
b867547
to
5ea761e
Compare
Add a flag to get the ipaddress from the binded information (ip/port).
/cc @containous/traefik
Signed-off-by: Vincent Demeester vincent@sbr.pm