Add possibility to use BindPort IPAddress 馃懠 #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @tqoliver |
|
Thanks @vdemeester :) , could you also update the doc? |
vdemeester
force-pushed
the
use-port-ip-address
branch
from
91bcffe
to
a17f189
Compare
|
@emilevauge does the name of the flag looks good ? 馃槤 |
vdemeester
force-pushed
the
use-port-ip-address
branch
2 times, most recently
from
4290204
to
679c4bd
Compare
| @@ -34,6 +34,7 @@ type Docker struct { | |||
| Domain string `description:"Default domain used"` | |||
| TLS *ClientTLS `description:"Enable Docker TLS support"` | |||
| ExposedByDefault bool `description:"Expose containers by default"` | |||
| UseBindPortIP bool `description:"Use the ip address from the port binded instead of the inner network one"` | |||
There was a problem hiding this comment.
The description could be a bit better here, the language feels a bit awkward...
Perhaps this would be better:
"Use the ip address from the bound port, rather than from the inner network"
|
This looks good to me... I quite like the name of the flag, its clear what it does :) |
|
Looks good to me, apart few comments :) |
vdemeester
force-pushed
the
use-port-ip-address
branch
from
679c4bd
to
f6c8d01
Compare
vdemeester
force-pushed
the
use-port-ip-address
branch
from
f6c8d01
to
b867547
Compare
|
Ping @vdemeester :) |
|
arf conflict on |
|
Do you still want to add an integration test? |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
use-port-ip-address
branch
from
b867547
to
5ea761e
Compare
emilevauge
approved these changes
Sep 20, 2016
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to get the ipaddress from the binded information (ip/port).
/cc @containous/traefik
Signed-off-by: Vincent Demeester vincent@sbr.pm