-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder migrations for v2 minor upgrades #7214
Conversation
Currently, the order of migrations is: `2.2.2 -> 2.2.5`. `2.0 -> 2.1`, `2.1 -> 2.2` This order is rather confusing, and I would propose to make it follow version numbers either top down, or bottom up. As someone wo is upgrading from 2.0 to 2.2, I can now follow the migrations one by one without checking the whole document, if there are other changes that might be important for the version skips I try to do.
Hello @peschmae, Indeed the order is wrong, but in the v2.3 we reorganized those minor migration guides in the following order: 2.0 -> 2.1, 2.1 -> 2.2, 2.2.2 -> 2.2.5 Thanks for your time and interest in Traefik! |
Hello @peschmae, I made the changes :) Thanks anyway 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This change reorders the migrations for v2 to follow the releases from bottom to top. (Oldest migrations at the bottom, newer ones at the top.)
Motivation
Currently, the order of migrations is:
2.2.2 -> 2.2.5
.2.0 -> 2.1
,2.1 -> 2.2
As someone wo is upgrading from 2.0 to 2.2, I can now follow the migrations one by one without checking the whole document, if there are other changes that might be important for the version skips I try to do.
More