Skip to content

Conversation

@peschmae
Copy link
Contributor

What does this PR do?

This change reorders the migrations for v2 to follow the releases from bottom to top. (Oldest migrations at the bottom, newer ones at the top.)

Motivation

Currently, the order of migrations is: 2.2.2 -> 2.2.5. 2.0 -> 2.1, 2.1 -> 2.2
As someone wo is upgrading from 2.0 to 2.2, I can now follow the migrations one by one without checking the whole document, if there are other changes that might be important for the version skips I try to do.

More

  • Updated documentation

Currently, the order of migrations is: `2.2.2 -> 2.2.5`.  `2.0 -> 2.1`, `2.1 -> 2.2`

This order is rather confusing, and I would propose to make it follow version numbers either top down, or bottom up. 
As someone wo is upgrading from 2.0 to 2.2, I can now follow the migrations one by one without checking the whole document, if there are other changes that might be important for the version skips I try to do.
@rtribotte
Copy link
Member

Hello @peschmae,

Indeed the order is wrong, but in the v2.3 we reorganized those minor migration guides in the following order: 2.0 -> 2.1, 2.1 -> 2.2, 2.2.2 -> 2.2.5
Do you think that you can make the changes to follow to the order we choose in the v2.3 documentation ?

Thanks for your time and interest in Traefik!

@rtribotte
Copy link
Member

Hello @peschmae,

I made the changes :)

Thanks anyway 👍

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants