Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers response modifier is directly applied by headers middleware #7230

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Aug 31, 2020

What does this PR do?

Remove global response modifier system and apply response modifier directly in headers middleware.

Motivation

Fixes #6790, #4273, #7003

More

  • Added/updated tests
    - [ ] Added/updated documentation

Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com

@juliens juliens added this to To review in v2 via automation Aug 31, 2020
@traefiker traefiker added this to the 2.2 milestone Aug 31, 2020
@mpl mpl changed the title Headers response modifier is directly apply on headers middleware Headers response modifier is directly applied on headers middleware Aug 31, 2020
@mpl mpl changed the title Headers response modifier is directly applied on headers middleware Headers response modifier is directly applied by headers middleware Aug 31, 2020
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants