-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers response modifier is directly applied by headers middleware #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpl
changed the title
Headers response modifier is directly apply on headers middleware
Headers response modifier is directly applied on headers middleware
Aug 31, 2020
mpl
changed the title
Headers response modifier is directly applied on headers middleware
Headers response modifier is directly applied by headers middleware
Aug 31, 2020
ldez
approved these changes
Sep 1, 2020
jbdoumenjou
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rtribotte
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
traefiker
force-pushed
the
response-modifier
branch
from
September 1, 2020 16:00
d2e0264
to
01724d3
Compare
This was referenced Sep 1, 2020
This was referenced Sep 20, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove global response modifier system and apply response modifier directly in headers middleware.
Motivation
Fixes #6790, #4273, #7003
More
- [ ] Added/updated documentationCo-authored-by: Ludovic Fernandez ldez@users.noreply.github.com