Skip to content

Headers response modifier is directly applied by headers middleware#7230

Merged
traefiker merged 5 commits intotraefik:v2.2from
juliens:response-modifier
Sep 1, 2020
Merged

Headers response modifier is directly applied by headers middleware#7230
traefiker merged 5 commits intotraefik:v2.2from
juliens:response-modifier

Conversation

@juliens
Copy link
Member

@juliens juliens commented Aug 31, 2020

What does this PR do?

Remove global response modifier system and apply response modifier directly in headers middleware.

Motivation

Fixes #6790, #4273, #7003

More

  • Added/updated tests
    - [ ] Added/updated documentation

Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com

@traefiker traefiker added this to the 2.2 milestone Aug 31, 2020
@mpl mpl changed the title Headers response modifier is directly apply on headers middleware Headers response modifier is directly applied on headers middleware Aug 31, 2020
@mpl mpl changed the title Headers response modifier is directly applied on headers middleware Headers response modifier is directly applied by headers middleware Aug 31, 2020
Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants