Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Teams connector webhook URL format changed #138

Closed
kevinlul opened this issue Feb 11, 2021 · 9 comments · Fixed by #167 or #211
Closed

Microsoft Teams connector webhook URL format changed #138

kevinlul opened this issue Feb 11, 2021 · 9 comments · Fixed by #167 or #211
Assignees

Comments

@kevinlul
Copy link

image

This causes teams:// URLs to fail as well as directly pasting the webhook URL for the Watchtower Teams integration, since it tries to parse the URL and use shoutrrr anyway.

@piksel
Copy link
Member

piksel commented Feb 11, 2021

This is fixed in v0.4.0 and should be included in the next watchtower release.

@papanito
Copy link

I guess docu should be updated as well: https://github.com/containrrr/shoutrrr/blob/main/docs/services/overview.md

@piksel
Copy link
Member

piksel commented Apr 28, 2021

Yeah, and I just noticed that they actually explain what the fields are above, documentation I wasn't able to find anywhere before.

@piksel piksel self-assigned this Apr 28, 2021
@papanito
Copy link

Yeah, and I just noticed that they actually explain what the fields are above, documentation I wasn't able to find anywhere before.

I actually don't find this documentation either.

@piksel piksel linked a pull request May 15, 2021 that will close this issue
@piksel
Copy link
Member

piksel commented May 15, 2021

This was addressed in #167, but the docs still contain some incorrect information:
https://containrrr.dev/shoutrrr/latest/services/teams/

Keeping this open until it's fixed.

@piksel piksel reopened this May 15, 2021
@LanJosh
Copy link

LanJosh commented Jul 6, 2021

Yeah, and I just noticed that they actually explain what the fields are above, documentation I wasn't able to find anywhere before.

I actually don't find this documentation either.

I can't seem to find this documentation either, what is the field supposed to be?

@piksel
Copy link
Member

piksel commented Jul 7, 2021

@LanJosh host. It's in the top Attention box in the docs:
https://containrrr.dev/shoutrrr/latest/services/teams/

If you are referring to how to get it, it's the hostname that your teams webhook URL starts with: xxxxxx.webhook.office.com

You can follow the guide in the teams docs to create a new one if you don't have one with the correct host.


The thing we referred to above regarding the docs was the fact that the image in the issue post actually explained what all of the fields in the magic webhook URLs were. We used to refer to them as tokenA, tokenB etc. since it wasn't clear what they were.

@igorcezar
Copy link

Since the webhook URL format changed, shouldn't this line also be able to set /webhookb2/?

"https://%s/webhook/%s@%s/IncomingWebhook/%s/%s",

It doesn't work for new URL format because it will build the url as https://<tName>.webhook.office.com/webhook/token..., which doesn't exist.

@piksel
Copy link
Member

piksel commented Aug 10, 2021

@igorcezar both the webhookb2 and webhook URLs worked in the integration tests (that's why it wasn't caught earlier). nevertheless, it was wrong and has been fixed in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants