New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teams: Generated webhook URL for custom domains is incorrect #187

Closed

piksel opened this issue Aug 10, 2021 · 0 comments · Fixed by #188

Milestone

Member

piksel commented Aug 10, 2021 •

edited

The generated teams URL for custom domains uses the old keyword webhook instead of webhookb2 which does not exist.

Since the webhook URL format changed, shouldn't this line also be able to set /webhookb2/?

shoutrrr/pkg/services/teams/teams_config.go

Line 106 in 23170b8

"https://%s/webhook/%s@%s/IncomingWebhook/%s/%s",

It doesn't work for new URL format because it will build the url as https://<tName>.webhook.office.com/webhook/token..., which doesn't exist.

Originally posted by @igorcezar in #138 (comment)

The text was updated successfully, but these errors were encountered:

piksel added this to the v0.5.0 milestone

piksel mentioned this issue

fix(teams): use correct path in webhook URL #188

Merged

piksel closed this as completed in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment