Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): dont panic on send http errors #114

Merged
merged 3 commits into from
Jan 12, 2021
Merged

fix(slack): dont panic on send http errors #114

merged 3 commits into from
Jan 12, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 11, 2021

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #114 (483ada4) into main (1290cec) will increase coverage by 1.10%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   52.79%   53.90%   +1.10%     
==========================================
  Files          55       55              
  Lines        1161     1165       +4     
==========================================
+ Hits          613      628      +15     
+ Misses        512      497      -15     
- Partials       36       40       +4     
Impacted Files Coverage Δ
pkg/services/slack/slack.go 63.63% <60.00%> (+41.41%) ⬆️
pkg/services/slack/slack_json.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1290cec...483ada4. Read the comment docs.

@simskij simskij merged commit 163ff52 into main Jan 12, 2021
@simskij simskij deleted the fix/slack-errors branch January 12, 2021 19:34
@piksel piksel added this to the v0.4.0 milestone Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants