Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pushover): send all devices in single request #115

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 11, 2021

,..and don't skip sending if devices is not provided

@piksel piksel linked an issue Jan 11, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #115 (0add3cc) into main (1290cec) will increase coverage by 5.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   52.79%   58.40%   +5.60%     
==========================================
  Files          55       55              
  Lines        1161     1166       +5     
==========================================
+ Hits          613      681      +68     
+ Misses        512      436      -76     
- Partials       36       49      +13     
Impacted Files Coverage Δ
pkg/services/pushover/pushover_config.go 90.00% <ø> (ø)
pkg/services/pushover/pushover.go 67.74% <100.00%> (+67.74%) ⬆️
pkg/services/slack/slack.go 63.63% <0.00%> (+41.41%) ⬆️
pkg/services/gotify/gotify.go 73.33% <0.00%> (+44.76%) ⬆️
pkg/services/gotify/gotify_config.go 86.66% <0.00%> (+86.66%) ⬆️
pkg/services/slack/slack_json.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1290cec...0add3cc. Read the comment docs.

@piksel piksel merged commit 94fef61 into main Jan 17, 2021
@piksel piksel deleted the fix/pushover-devices branch January 17, 2021 10:17
@piksel piksel added this to the v0.4.0 milestone Jan 23, 2021
@whvanderpost
Copy link

Hi,
Today I was trying to get Watchtower to also send Pushover notifications with Shoutrrr and noticed that I have to supply the device parameter otherwise no message is being pushed.
Does the change in this code also end up in the Watchtower project or will Watchtower always require a device parameter?

@piksel
Copy link
Member Author

piksel commented Feb 12, 2021

It should be included in the next release of watchtower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushover should send to all devices if none are specified
2 participants