Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotify): use pkr for fields to make them settable from url #116

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 12, 2021

This adds the title and priority fields to the config and URL (previously only settable with params).
It also adds support for disabling TLS for non-https servers.

Ref: containrrr/watchtower#761

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #116 (3f2846b) into main (1290cec) will increase coverage by 2.61%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   52.79%   55.41%   +2.61%     
==========================================
  Files          55       55              
  Lines        1161     1164       +3     
==========================================
+ Hits          613      645      +32     
+ Misses        512      479      -33     
- Partials       36       40       +4     
Impacted Files Coverage Δ
pkg/services/gotify/gotify_config.go 86.66% <75.00%> (+86.66%) ⬆️
pkg/services/gotify/gotify.go 73.33% <81.81%> (+44.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1290cec...3f2846b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants