Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smtp): add date header and make enums public #118

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 13, 2021

  • Add missing required Date: header
  • Make AuthTypes and EncMethods enum helpers public

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #118 (9e28a0c) into main (1290cec) will increase coverage by 3.84%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   52.79%   56.64%   +3.84%     
==========================================
  Files          55       55              
  Lines        1161     1167       +6     
==========================================
+ Hits          613      661      +48     
+ Misses        512      462      -50     
- Partials       36       44       +8     
Impacted Files Coverage Δ
pkg/services/smtp/smtp_authtype.go 0.00% <0.00%> (ø)
pkg/services/smtp/smtp_encmethod.go 62.50% <33.33%> (+6.94%) ⬆️
pkg/services/smtp/smtp.go 81.42% <90.00%> (+0.13%) ⬆️
pkg/services/smtp/smtp_config.go 87.09% <100.00%> (ø)
pkg/services/slack/slack.go 63.63% <0.00%> (+41.41%) ⬆️
pkg/services/gotify/gotify.go 73.33% <0.00%> (+44.76%) ⬆️
pkg/services/gotify/gotify_config.go 86.66% <0.00%> (+86.66%) ⬆️
pkg/services/slack/slack_json.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1290cec...9e28a0c. Read the comment docs.

@piksel piksel merged commit c7b9fb9 into main Jan 17, 2021
@piksel piksel deleted the fix/smtp-date branch January 17, 2021 10:18
@piksel piksel added this to the v0.4.0 milestone Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant