Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make xmpp compatible with latest version #122

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 17, 2021

go get -u can be run without breaking the build
this also includes patch updates of the dependencies

`go get -u` can be run without breaking the build
this also includes patch updates of the dependencies
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #122 (1d042d0) into main (c7b9fb9) will decrease coverage by 0.38%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   58.54%   58.15%   -0.39%     
==========================================
  Files          55       55              
  Lines        1165     1171       +6     
==========================================
- Hits          682      681       -1     
- Misses        434      440       +6     
- Partials       49       50       +1     
Impacted Files Coverage Δ
pkg/services/xmpp/xmpp.go 27.27% <11.11%> (-8.73%) ⬇️
pkg/services/xmpp/xmpp_config.go 50.00% <100.00%> (ø)
pkg/services/rocketchat/rocketchat.go 14.28% <0.00%> (-3.90%) ⬇️
pkg/services/smtp/smtp_encmethod.go 62.50% <0.00%> (ø)
pkg/services/standard/standard_failures.go 0.00% <0.00%> (ø)
pkg/services/smtp/smtp.go 82.01% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b9fb9...1d042d0. Read the comment docs.

@piksel piksel merged commit 6e64c70 into main Jan 23, 2021
@piksel piksel deleted the fix/xmpp-v0.5-compat branch January 23, 2021 10:19
@piksel piksel added this to the v0.4.0 milestone Jan 23, 2021
@piksel piksel mentioned this pull request Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant