Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve outstanding golint errors #124

Merged
merged 1 commit into from
Jan 23, 2021
Merged

fix: resolve outstanding golint errors #124

merged 1 commit into from
Jan 23, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 21, 2021

Fixes the various errors that show up when running golint ./... locally, effectively hiding any relevant problems in the noise.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #124 (cb3adaf) into main (c7b9fb9) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   58.54%   58.55%   +0.01%     
==========================================
  Files          55       55              
  Lines        1165     1163       -2     
==========================================
- Hits          682      681       -1     
+ Misses        434      433       -1     
  Partials       49       49              
Impacted Files Coverage Δ
pkg/services/smtp/smtp.go 82.01% <0.00%> (+0.58%) ⬆️
pkg/services/smtp/smtp_encmethod.go 62.50% <ø> (ø)
pkg/services/standard/standard_failures.go 0.00% <ø> (ø)
pkg/services/rocketchat/rocketchat.go 14.28% <100.00%> (-3.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b9fb9...cb3adaf. Read the comment docs.

@piksel piksel added this to the v0.4.0 milestone Jan 23, 2021
@piksel piksel merged commit 7558049 into main Jan 23, 2021
@piksel piksel deleted the fix/golint branch January 23, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant