Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(send): use StringArray flag for url to not split on commas #129

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 28, 2021

The send cli command uses StringSlice for the URL argument which will split the input string by ",". This prevents commas from being used in service URLs which is perfectly valid from other usages.
This will change URL to instead use StringArray, which will keep the input intact, but supplying it multiple times adds to the array.
Example:

shoutrrr send -u gotify://localhost/token -u logger:// -m Message -t Title
or
shoutrrr send -u gotify://localhost/token Message -u logger:// -t Title

(first and second non-flag argument are still URL and Message respectively)

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #129 (ccaffc0) into main (84ec2ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   59.96%   59.96%           
=======================================
  Files          55       55           
  Lines        1184     1184           
=======================================
  Hits          710      710           
  Misses        424      424           
  Partials       50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ec2ed...ccaffc0. Read the comment docs.

@piksel piksel merged commit 568c1bc into main Jan 28, 2021
@piksel piksel deleted the fix/cli-send-url-commas branch January 28, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant