Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discord): rename channel into webhook ID #159

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 2, 2021

Note: Breaking change for anything explicitly passing a config struct to the discord service (which should normally never be the case).

fixes #156

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #159 (a78dd7c) into next (28298f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #159   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files          76       76           
  Lines        2262     2262           
=======================================
  Hits         1558     1558           
  Misses        572      572           
  Partials      132      132           
Impacted Files Coverage Δ
pkg/services/discord/discord.go 55.55% <100.00%> (ø)
pkg/services/discord/discord_config.go 82.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28298f4...a78dd7c. Read the comment docs.

@piksel piksel merged commit 2a0be16 into next Apr 19, 2021
@piksel piksel deleted the fix/discord-webhookid branch April 19, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant