Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matrix docs to mention title caveat #354

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update matrix docs to mention title caveat #354

merged 2 commits into from
Jun 27, 2023

Conversation

simskij
Copy link
Member

@simskij simskij commented May 24, 2023

Updates the docs to include a note on the caveat with title not being used for Matrix messages.

resolves #335

@simskij simskij requested a review from piksel May 24, 2023 08:26
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dbeab99) 78.92% compared to head (7cc3300) 78.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files         101      101           
  Lines        4431     4431           
=======================================
  Hits         3497     3497           
  Misses        756      756           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title field is such a wildcard. This note applies to some other services as well. But yeah, thanks for making a PR for the docs.

docs/services/matrix.md Outdated Show resolved Hide resolved
Co-authored-by: nils måsén <nils@piksel.se>
@simskij simskij merged commit 11cd546 into main Jun 27, 2023
2 checks passed
@simskij simskij deleted the simskij-patch-1 branch June 27, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix: Title is not used
2 participants