Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix an incorrect printf and add a missing error check #408

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Nov 5, 2023

This PR fixes a few minor issues I noticed when checking the code.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (52149dc) 79.18% compared to head (481b5ab) 79.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   79.18%   79.12%   -0.07%     
==========================================
  Files         102      102              
  Lines        4487     4488       +1     
==========================================
- Hits         3553     3551       -2     
- Misses        756      758       +2     
- Partials      178      179       +1     
Files Coverage Δ
pkg/services/slack/slack.go 72.30% <25.00%> (-4.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches!

@piksel piksel merged commit f4e1c7c into containrrr:main Nov 5, 2023
6 of 8 checks passed
@favonia favonia deleted the more-fixes branch November 5, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants