fix(notifications): title customization #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
+ Coverage 63.00% 63.60% +0.60%
==========================================
Files 23 23
Lines 1500 1522 +22
==========================================
+ Hits 945 968 +23
+ Misses 471 470 -1
Partials 84 84
Continue to review full report at Codecov.
|
piksel
force-pushed
the
fix/notify-titles
branch
from
494859c
to
f27bd38
Compare
simskij
approved these changes
Mar 20, 2022
Comment on lines
+247
to
+250
| type StaticData struct { | ||
| Title string | ||
| Host string | ||
| } |
There was a problem hiding this comment.
Could this naming be improved to clarify what it is? StaticData is very generic.
There was a problem hiding this comment.
It is, but it's the best way I found to describe it. It's the non-changing (static) part of the data used for notifications. It could perhaps be called StaticTemplateData, but it's not, strictly speaking, only used for that.
Any suggestions?
piksel
force-pushed
the
fix/notify-titles
branch
from
f3986cb
to
2407452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new flags to watchtower:
--notification-skip-titleand
--notification-title-tag <TAG>(with a backwards compatible alias tonotification-email-subjecttag).The
title-tagflag works the same way as theemail-subjecttagused to work. If supplied, it will prefix the titles for all notifications with[<TAG>]. Since it is generic among all notifications (which support titles), it was renamed to reflect this, but using the old name still works for now. Fixes #1205Supplying the
skip-titleflag will not override thetitleparam for the shoutrrr service, so it can still be set to whatever value you want using the&title=query parameter of the shoutrrr URL. This should in effect remove the title if no such query param is supplied. Fixes #1207This was done in a combined effort to simplify the title generation and fixing the unintended breaking changes in 1.4.0