Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): add general notification delay #1246

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

lazou
Copy link
Contributor

@lazou lazou commented Mar 8, 2022

This PR will add the possibility to define a delay before sending a notification in the new notification system with notifications-delay. The legacy delay for emails (notification-email-delay) will still work and overwrite the general delay.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look really good. Perhaps we should even remove the email-specific delay code to reduce complexity more.
We can just put make the --notification-email-delay an alias for --notifications-delay to make it backwards compatible. That can be done in another PR though.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1246 (3ede579) into main (f79e4b5) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
+ Coverage   62.70%   63.00%   +0.29%     
==========================================
  Files          23       23              
  Lines        1488     1500      +12     
==========================================
+ Hits          933      945      +12     
  Misses        471      471              
  Partials       84       84              
Impacted Files Coverage Δ
internal/flags/flags.go 88.82% <100.00%> (+0.17%) ⬆️
pkg/notifications/notifier.go 80.00% <100.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79e4b5...3ede579. Read the comment docs.

@piksel piksel changed the title feat(notifications): add notification delay feat(notifications): add general notification delay Mar 9, 2022
@piksel piksel merged commit a5c60a9 into containrrr:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants