Expand docker.config section #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlight the benefit of doing this if using 2FA on Docker Hub
Codecov Report
@@ Coverage Diff @@
## main #1316 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 23 23
Lines 1534 1534
=======================================
Hits 979 979
Misses 465 465
Partials 90 90 Continue to review full report at Codecov.
|
|
sorry had renamed my branches so they made more sense, didn't realise that would automatically close the PR! |
|
Yeah, you cannot change the source branch, so if the branch is renamed, the PR is automatically closed as the source branch doesn't exist anymore. |
|
Thanks, @piksel - live and learn 😂 I've restored those branches and the PRs 👍 |
simskij
approved these changes
Aug 4, 2022
|
@all-contributors add @EDIflyer for docs |
|
I've put up a pull request to add @EDIflyer! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to documentation to highlight the benefit of doing this if using 2FA on Docker Hub