chore(deps): update go version to 1.18 #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 64.71% 64.71%
=======================================
Files 23 23
Lines 2293 2293
=======================================
Hits 1484 1484
Misses 712 712
Partials 97 97
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
using go 1.18, the `go get` command does no longer install golint. but since it's deprecated anyway, let's replace it with staticcheck
internal/actions/mocks/progress.go: - ineffective break statement. Did you mean to break out of the outer loop? (SA4011) - redundant break statement (S1023) pkg/container/client.go: - should omit comparison to bool constant, can be simplified to execInspect.Running (S1002) - error strings should not be capitalized (ST1005) pkg/container/errors.go: - var errorNoExposedPorts is unused (U1000) pkg/registry/auth/auth.go: - argument err is overwritten before first use (SA4009) - the argument is already a string, there's no need to use fmt.Sprintf (S1025) pkg/registry/trust.go: - error strings should not be capitalized (ST1005)
piksel
changed the title
|
I am limiting this to only be the update to go v1.18, as it had some cascading consequences and dependabot already has a PR for the prometheus dependency: #1365 |
|
Code coverage is low in lint-fixed areas, not something this PR should address. Force merging. |
piksel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While scanning a locally built copy of watchtower using Trivy, the container showed
CVE-2022-21698as being flagged as an issue. Upon investigation, this turns out to begithub.com/prometheus/client_golangnot being v1.11 or newer.I also noticed that go.mod is set to 1.12 so bumped that up to the lowest current supported version: 1.18 using
go get -u all && go mod tidyThis resulted in the following modules versions being updated:
I have built a test image which can be pulled using
docker pull jauderho/watchtower:git. My initial testing does not show any issues.