Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to improve the private registry docs #633

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

chander
Copy link
Contributor

@chander chander commented Aug 29, 2020

Add in a more complete example related to setting up ECR as a private registry with watchtower.

@piksel
Copy link
Member

piksel commented Aug 29, 2020

Ref #103

I know it's totally OK to enumerate a list using the same number in markdown, but for the sake of people reading the raw docs, I'd still like them to be numbered.
Also removed a superfluous `version: 3` and made sure all other versions were set to `"3.4"`.
Copy link
Member

@simskij simskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your excellent contribution! 🥳 🎉

@simskij
Copy link
Member

simskij commented Oct 3, 2020

@all-contributors add @chander for docs

@simskij simskij merged commit 16a79d9 into containrrr:master Oct 3, 2020
@allcontributors
Copy link
Contributor

@simskij

I've put up a pull request to add @chander! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants