Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loadDataContainer for load Class #50

Merged
merged 2 commits into from Jan 19, 2023
Merged

Fix loadDataContainer for load Class #50

merged 2 commits into from Jan 19, 2023

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented Jan 18, 2023

Fix loadDataContainer for load Class

@zonky2 zonky2 added the Defect label Jan 18, 2023
@zonky2 zonky2 added this to the 2.1.1 milestone Jan 18, 2023
@zonky2 zonky2 self-assigned this Jan 18, 2023
@zonky2 zonky2 force-pushed the hotfix/fix_loaddatacontainer_for_class branch from b74264d to fc87a1e Compare January 18, 2023 15:38
discordier
discordier approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the psalm issues, this looks good to me.

@zonky2 zonky2 force-pushed the hotfix/fix_loaddatacontainer_for_class branch 2 times, most recently from 065b504 to 88bb85d Compare January 18, 2023 15:54
@zonky2 zonky2 force-pushed the hotfix/fix_loaddatacontainer_for_class branch from 88bb85d to 5951fc4 Compare January 18, 2023 15:57
@stefanheimes stefanheimes merged commit 587b506 into master Jan 19, 2023
@stefanheimes stefanheimes deleted the hotfix/fix_loaddatacontainer_for_class branch January 19, 2023 23:37
@dmolineus
Copy link
Member

Doctrine\DBAL\Connection::createSchemaManager was introduced in doctrine/dbal 3.4, we still require ^2.11 || ^3.0 (

meta-palettes/composer.json

Line 35 in a2d9cdd

"doctrine/dbal": "^2.11 || ^3.1",
). You introduced another bug here.

zonky2 added a commit that referenced this pull request Jan 20, 2023
@zonky2
Fix PR #50 - reset the schema manager
60054ac
@zonky2 zonky2 mentioned this pull request Jan 20, 2023
Merged
@zonky2
Copy link
Contributor Author

zonky2 commented Jan 20, 2023

Fix: #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordier discordier discordier approved these changes

Assignees

@zonky2 zonky2

Labels
Defect
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zonky2 @dmolineus @discordier @stefanheimes