This repository has been archived by the owner on Jan 2, 2020. It is now read-only.
add xmlreader extension check #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Apr 20, 2018
|
Hm, I think I need to add this to Contao 2 and 3 as well, technically. Contao uses |
|
I have updated the PR. |
|
@leofeyer any objections to expanding it to Contao 2 & 3? |
|
No real objections. I generally do not think that we need this check, as this is the first time in over 10 years that someone has reported this problem and there is not a single PHP package for any unix OS that has been compiled with the |
|
I agree, it's very unusual - but it doesn't hurt to keep it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #141