Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom table deletion default checked #739

Closed
Kahmoon opened this issue Oct 21, 2022 · 10 comments
Closed

Custom table deletion default checked #739

Kahmoon opened this issue Oct 21, 2022 · 10 comments
Labels
Milestone

Comments

@Kahmoon
Copy link

Kahmoon commented Oct 21, 2022

Hi,

the install tool marks the checkbox to delete tables by default. This behaviour is risky to accidently delete custom tables.

SCR-20221021-fkq

Greetz

@ausi
Copy link
Member

ausi commented Oct 21, 2022

As there is a backup of the database automatically before executing the migrations I’m not sure if this is considered risky.

@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2022

I think it is, because if you lost data unnoticed, it will be at the very least inconvenient to restore and at worst impossible due to the backup retention policy.

@aschempp aschempp added the bug label Oct 21, 2022
@aschempp aschempp added this to the 1.6 milestone Oct 21, 2022
@Kahmoon
Copy link
Author

Kahmoon commented Oct 21, 2022

As there is a backup of the database automatically before executing the migrations I’m not sure if this is considered risky.

Didn´t know that. Where is this backup in case i would need it?

@ausi
Copy link
Member

ausi commented Oct 24, 2022

Where is this backup in case i would need it?

https://docs.contao.org/manual/de/cli/datenbank-backups/

@Kahmoon
Copy link
Author

Kahmoon commented Oct 24, 2022

Where is this backup in case i would need it?

https://docs.contao.org/manual/de/cli/datenbank-backups/

I don´t want to create a backup (i already got one). I thought contao install tool will create automatically a backup when doing db updates :-D. Misunderstanding sorry :-)

@fritzmg
Copy link
Contributor

fritzmg commented Oct 24, 2022

As already said, Contao automatically creates a backup.

@Kahmoon
Copy link
Author

Kahmoon commented Oct 24, 2022

OK? I misunderstood!
I just did an update and at var/backups there is a backup. Now i get it :)

@Toflar
Copy link
Member

Toflar commented Oct 24, 2022

Running contao:migrate does. So the Manager does as well.

@aschempp
Copy link
Member

aschempp commented Nov 2, 2022

Running contao:migrate does. So the Manager does as well.

In Contao 4.13+ that is! Not for Contao 4.9 though. I will change the checkbox to be unchecked by default, since that's also the default behaviour of the command.

@aschempp aschempp modified the milestones: 1.6, 1.6.2 Jan 12, 2023
@aschempp
Copy link
Member

Fixed in version 1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants