Added review comments

contao · Jan 13, 2024 · 2ea63d7 · 2ea63d7
1 parent 03b5b56
commit 2ea63d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/core-bundle/src/Routing/Content/ContentUrlResult.php b/core-bundle/src/Routing/Content/ContentUrlResult.php
@@ -42,6 +42,9 @@ public function hasTargetUrl(): bool
         return \is_string($this->content);
     }
 
+    /**
+     * @return string An absolute URL.
+     */
     public function getTargetUrl(): string
     {
         if (!$this->hasTargetUrl()) {

diff --git a/core-bundle/src/Routing/ContentUrlGenerator.php b/core-bundle/src/Routing/ContentUrlGenerator.php
@@ -176,6 +176,7 @@ private function getRouteKey(object $content): string
             return sprintf('%s.%s', $content::getTable(), $content->{$content::getPk()});
         }
 
+        // If the content is a Doctrine ORM entity, try using its identifier
         try {
             $metadata = $this->entityManager->getClassMetadata($content::class);
         } catch (MappingException) {