Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contao 4.9.2: News -> target = external URL -> 1 in frontend #1707

Closed
math-GH opened this issue May 6, 2020 · 1 comment · Fixed by #1732
Closed

Contao 4.9.2: News -> target = external URL -> 1 in frontend #1707

math-GH opened this issue May 6, 2020 · 1 comment · Fixed by #1732
Assignees
@leofeyer
Labels
bug
Milestone
4.9

Comments

@math-GH
Copy link

math-GH commented May 6, 2020

Contao 4.9.2

News-Bundle

Target = external URL
grafik

creates a "1" in the frontend.
grafik

event_list.html5: $this->details
it echos a bool(1)
grafik

because of ModuleEventReader.php Line 231
grafik

This "1" I do not expect.
@contaoacademy
Copy link

Same for calender. See https://community.contao.org/de/showthread.php?76873-Kalender-Liste-zeigt-statt-Details-nur-eine-quot-1-quot&p=519011#post519011

@leofeyer leofeyer mentioned this issue May 12, 2020
Closed
@leofeyer leofeyer added the bug label May 12, 2020
@leofeyer leofeyer added this to the 4.9 milestone May 12, 2020
@leofeyer leofeyer self-assigned this May 12, 2020
@leofeyer leofeyer mentioned this issue May 12, 2020
Merged
@leofeyer leofeyer linked a pull request May 12, 2020 that will close this issue
Redirect if a news/event has an external target and is called via the default URL #1732
Merged
leofeyer added a commit that referenced this issue May 12, 2020
@leofeyer
Redirect if a news/event has an external target and is called via the…
ed3a3f4 
… default URL (see #1732)

Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | Fixes #1707 #1498
| Docs PR or issue | -

Commits
-------

972627f Redirect if a news/event has an external target and is called via the default URL
ef11121 Show the teaser if there are no details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging a pull request may close this issue.

Redirect if a news/event has an external target and is called via the default URL leofeyer/contao
3 participants
@leofeyer @math-GH @contaoacademy